Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redefining WIN32_LEAN_AND_MEAN on Windows #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid redefining WIN32_LEAN_AND_MEAN on Windows #87

wants to merge 1 commit into from

Conversation

bernardosulzbach
Copy link

This causes warnings for people integrating cppcoro's sources in their projects without using your CMakeLists.

Other files already do the #ifndef check.

Thanks.

@bernardosulzbach
Avoid redefining WIN32_LEAN_AND_MEAN on Windows
ee5e2d8 
This causes warnings for people integrating cppcoro's sources in their projects without using your CMakeLists.

Other files already do the #ifndef check.
@andreasbuhr
Copy link
Owner

Thank you very much.
It seems there are some CI errors popping up, unrelated to your change. I'll fix them in main, then rebase your PR on the new main and then merge it. Thank you for your patience.

@bernardosulzbach
Copy link
Author

There's no rush. I had to patch those files anyway and decided I'd just offer the diffs upstream. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernardosulzbach @andreasbuhr